RFR: 8276661: (fs) UserDefinedFileAttributeView no longer works with long path (win) [v7]

[Alan Bateman]

On Wed, 1 Dec 2021 23:48:59 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Please consider this change which uses a new method `WindowsPath::getPathWithPrefixForWin32Calls`.
>
> Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
> 
>  - Merge
>  - 8276661: Ensure GetFullPathName() is used
>  - 8276661: Change getPathWithPrefixForWin32Calls to getPathWithPadForWin32Calls
>  - 8276661: addPrefixIfNeeded calls addPrefix; remove UNC test
>  - 8276661: Replace addPrefixIfAbsent() with addPrefix()
>  - 8276661: Support UNC paths
>  - 8276661: (fs) UserDefinedFileAttributeView no longer works with long path (win)

The latest revision looks good and I think we were lucky that the CheckPermissions test caught the issue.

One suggestion is to invert forceLongPrefix to something like allowShortPath. I think this would make getPathForWin32Calls a bit easier to read because because it avoid two uses of !forceLongPrefix.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6435