RFR: 8277361: java/nio/channels/Channels/ReadXBytes.java fails with OOM error
Lance Andersen
lancea at openjdk.java.net
Tue Dec 7 12:04:12 UTC 2021
On Tue, 7 Dec 2021 01:47:47 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
> This request would increase the amount of heap memory that the test can use, and decrease execution time by not writing the entirety of test files.
Looks good Brian
Minor suggestion below
test/jdk/java/nio/channels/Channels/ReadXBytes.java line 105:
> 103: try (FileChannel fc = FileChannel.open(file, WRITE);) {
> 104: long pos = 0L;
> 105: if (length >= 2L*1024*1024*1024) {
Maybe consider a constant or a comment for extra clarity
-------------
Marked as reviewed by lancea (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/6732
More information about the nio-dev
mailing list