RFR: 8271079: JavaFileObject#toUri and multi-release jars [v2]

Christian Stein cstein at openjdk.java.net
Fri Dec 10 08:16:51 UTC 2021


On Thu, 9 Dec 2021 18:37:11 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Christian Stein has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Clean up reproducer test case
>>  - Keep helper in ZipFileSystem simple
>
> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipPath.java line 211:
> 
>> 209: 
>> 210:     private String getRealPath(byte[] resolvedPath) {
>> 211:         byte[] path = zfs.lookupPath(resolvedPath);
> 
> Can getRealPath be changed to be no-arg method that calls getResolvedPath and then does the lookup. I think that would be a clearer than assuming the argument is a resolved path.

Done via https://github.com/openjdk/jdk/pull/6768/commits/12e106c6e69449f1fbde9e5b6a5ff3305c5de547

-------------

PR: https://git.openjdk.java.net/jdk/pull/6768


More information about the nio-dev mailing list