RFR: 8278268 - (ch) InputStream returned by Channels.newInputStream should have fast path for FileChannel targets [v7]

[Markus KARG]

On Wed, 22 Dec 2021 13:30:40 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>>> Ah, right, seems I missed that section about the one-byte-guarantee. Great, so I kindly request approval of this PR!
>> 
>> I think Lance is going to help on this. We need to study the test update closely as this test has been causing a lot of issues in our CI (timeouts, hangs, ...).  I think the main issue with the test right now is JDK-8278369 and it may only be on Windows. I haven't had time myself to study it closely.
>
>> @AlanBateman Seems Lance has no time (or is possibly on holidays) so I kindly ask for approval again, as everything he asked me for is fixed in this PR since a week already.
> 
> I've been busy and haven't been following the recent discussions about the test. Lance has been busy too but I think he has been looking at the tests. He mentioned that the new TransferTo2 tests actually runs TransferTo due to an issue with the @run tag. I will try to get time to look at the test soon. Once this PR is in integrated then I think JDK-8278369 should be priority, I think that issue may be Windows specific.

Good catch! Silly me. Fixed in https://github.com/openjdk/jdk/pull/6711/commits/fc7d00bf20861276e11e755c6794999eca95049d.

 JDK-8278369: Tried several times on my Windows 11 laptop, but still cannot reproduce. Maybe Lance's boxes are simply overloaded / too slow?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6711