RFR: 8278268 - (ch) InputStream returned by Channels.newInputStream should have fast path for FileChannel targets [v8]

[Lance Andersen]

On Thu, 16 Dec 2021 17:26:04 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>>> > We will have to separate out the added changes into its own test as we are failing sporadically on some of the windows boxes due to the execution time.
>>> 
>>> @LanceAndersen Do I understand correct, _ontop_ of the diff you sent me, you also want me to strip all 2GB tests into a separate test class, correct?
>> 
>> The updates that you made to add an additional test is resulting in sporadic timeouts on Windows.  
>> 
>> - Please revert TransferTo.Java to omit  the changes you made to it as part of this PR
>> - -  Yes, we should cleanup TransferTo.java  while we are addressing this test area
>> - Add a new test file to address your changes to ChannelInputStream found in this PR
>
>> @LanceAndersen Are you sure that the sporadic timeout comes from the changes made by _this_ PR? IIUC then the sporadic timeouts are found _in the master branch_, so reverting the changes from _this_ PR do not bring a benefit. It would be better to separate out _all_ (_even existing_) 2GB tests instead.
> 
> As I mentioned in my earlier comment, we need to make the changes as outlined.  We do have some Windows boxes which are older but we cannot afford to have sporadic test failures due to the disruption it causes.  And yes, these failures are occurring with the changes made and do not occur if I back them out.
> 
> So please follow the recommendations, I can then re-test the PR to validate we are clean (or as clean as we ca)n for sporadic failures.

> @LanceAndersen I assumed the second test will exist only for the time until we fixed the Windows problems, so I did not invest time to reduce duplication so far. So you really want to keep the separated tests forever and want me to reduce duplication?

I would not make any such assumptions especially for tests that create large files.  So yes please address the duplication.  It is not a huge amount of work to  create a base class that the tests extend (you will see examples elsewhere within the various test directories).

-------------

PR: https://git.openjdk.java.net/jdk/pull/6711