RFR: 8278268 - (ch) InputStream returned by Channels.newInputStream should have fast path for FileChannel targets [v15]

[Lance Andersen]

On Thu, 23 Dec 2021 09:48:00 GMT, Markus KARG <duke at openjdk.java.net> wrote:

>> This sub-issue defines the work to be done to implement JDK-8265891 solely for the particular case of FileChannel.transferFrom(ReadableByteChannel), including special treatment of SelectableByteChannel.
>
> Markus KARG has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removing unused imports
>   
>   Signed-off-by: Markus Karg <markus at headcrashing.eu>

Thank you for the current updates.  We are starting to move in the right direction.

Alan and I had an offline conversation and concluded the following changes should be made:

- Rename the base class as it is not an Abstract class so the name is confusing
- The base class should only contain constants and helper/utility methods. The actual  tests should reside  in the test classes
- That the tests should be broken out  as
  -  A separate test class for each large file test with a more descriptive class name
  -  A  primary TransferTo test class which includes the remaining tests

After the next set of updates, I will kick off some additional Mach5 runs

I realize that we are spending a lot of time on the tests but they are a key aspect of making sure we have adequate coverage for changes such as this and are easy to maintain and understand by future maintainers/developers

-------------

PR: https://git.openjdk.java.net/jdk/pull/6711