RFR: 8260875 (sc)SocketAdaptor$SocketInputStream read throws IllegalBlockingModeException on closed channel

[hedongbo]

Hi Alan, is this 8u webrev ok? I saw that you said patch was fine in the last email, so I added jdk8u-fix-request label to JDK-6878250, but Andrew said that the patch had not been reviewed. Do I need to make any modifications to the patch?


webrev: http://cr.openjdk.java.net/~dongbohe/6878250/webrev.00/

bug: https://bugs.openjdk.java.net/browse/JDK-6878250


Thanks,
dongbohe

From: hedongbo
Sent: Wednesday, February 3, 2021 6:44 PM
To: 'Alan Bateman' <Alan.Bateman at oracle.com>
Cc: nio-dev at openjdk.java.net
Subject: RE: RFR: 8260875 (sc)SocketAdaptor$SocketInputStream read throws IllegalBlockingModeException on closed channel


Thank you for your review, Alan.



I changed the bug to JDK-6878250, and added jdk8-fix label on JDK-6878250

webrev: http://cr.openjdk.java.net/~dongbohe/6878250/webrev.00/

bug: https://bugs.openjdk.java.net/browse/JDK-6878250



At the same time, I have sent an email to jdk-updates-dev to backport JDK-8246707 to jdk11u



Thanks,
dongbohe

From: Alan Bateman [mailto:Alan.Bateman at oracle.com]
Sent: Wednesday, February 3, 2021 1:23 AM
To: hedongbo <hedongbo at huawei.com<mailto:hedongbo at huawei.com>>; nio-dev at openjdk.java.net<mailto:nio-dev at openjdk.java.net>
Subject: Re: RFR: 8260875 (sc)SocketAdaptor$SocketInputStream read throws IllegalBlockingModeException on closed channel

On 02/02/2021 09:33, hedongbo wrote:
Yes, I want to fix this on 8. Webrev is also for 8.
Backport JDK-8246707 to 11 can solve this problem in 11, and I am doing this backport.

Okay. Feel free to re-open JDK-8260875 if it easier for you. I'm not involved in JDK updates so you'll need to follow the process for the updates releases (the patch to SocketAdaptor in your patch is fine).

JDK-8246707 is a different issue. This is the throwing of AsynchronousCloseException instead of ClosedClosedException which can be confusing. That could be fixed in 11u, should not be an issue in 8u.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20210204/93f00b1a/attachment.htm>