[EXTERNAL] Re: Bug in Files.isSameFile(Path,Path)

Alan Bateman Alan.Bateman at oracle.com
Thu Feb 4 14:06:16 UTC 2021


On 02/02/2021 21:56, Nhat Nguyen wrote:
> Hi Alan,
>
> It has been a while since we last had this conversation. I just want to ask if
> you are still interested in investigating more into this issue?
>
Thanks for the reminder. Yes, it would be great to continue the 
investigation if you have the cycles.

I think we were in agreement to re-implement isSameFile. If we can move 
away from checking volume/file IDs with GetFinalPathNameByHandle then 
that would be great but I think we need to make sure that it doesn't 
introduce any inconsistencies with toRealPath. I think we also want to 
make sure that the approach works with as many different file systems as 
there is a history of problems with some configurations (CIFS servers, 
SAMBA, WebDAV, ...). There was also discussion on use 64-bit file IDs 
and GetFileInformationByHandleEx so that would be good to explore too. 
Our discussion touched on having a fallback approach too but it would be 
nice not to need that, partly because it would be code that isn't 
exercised during regular testing.

-Alan.




More information about the nio-dev mailing list