RFR: 8260875 (sc)SocketAdaptor$SocketInputStream read throws IllegalBlockingModeException on closed channel

[hedongbo]

Thanks Alan and Roger for your advice.


Thanks,
dongbohe

From: Roger Riggs [mailto:roger.riggs at oracle.com]
Sent: Thursday, February 4, 2021 10:58 PM
To: hedongbo <hedongbo at huawei.com>
Cc: nio-dev at openjdk.java.net
Subject: Re: RFR: 8260875 (sc)SocketAdaptor$SocketInputStream read throws IllegalBlockingModeException on closed channel

Reviews for 8u are done on a different email list:

    jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>

Regards, Roger

On 2/4/21 9:31 AM, Alan Bateman wrote:
On 04/02/2021 08:55, hedongbo wrote:

Hi Alan, is this 8u webrev ok? I saw that you said patch was fine in the last email, so I added jdk8u-fix-request label to JDK-6878250, but Andrew said that the patch had not been reviewed. Do I need to make any modifications to the patch?


webrev: http://cr.openjdk.java.net/~dongbohe/6878250/webrev.00/

bug: https://bugs.openjdk.java.net/browse/JDK-6878250

I'm not involved the JDK 8 update releases. The update to SocketAdaptor.java is good for JDK-6878250. The test in the webrev isn't testing the right scenario. Also if the thread created by testReadAfterClose throws an exception then it's not communicated to the main thread. To create the scenario you need to configure the SocketChannel to be non-blocking, close it, then check that ClosedChannelException is thrown.

-Alan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20210205/bd252ad1/attachment.htm>