RFR: 8252971: WindowsFileAttributes does not know about Unix domain sockets [v2]

[Michael McMahon]

On Sat, 6 Feb 2021 17:10:39 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Michael McMahon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8252971-socket-attributes
>>  - update
>>  - update
>>  - update
>>  - update
>>  - update after Alan's first review
>>  - Merge branch 'master' into 8252971-socket-attributes
>>  - test update
>>  - initial fix for review
>
> src/java.base/windows/classes/sun/nio/fs/WindowsPath.java line 866:
> 
>> 864: 
>> 865:         try {
>> 866:             // needs one additional flag to open a Unix domain socket
> 
> The comment here is confusing as there are two flags.

Okay

> src/java.base/windows/classes/sun/nio/fs/WindowsPath.java line 859:
> 
>> 857: 
>> 858:     /**
>> 859:      * returns INVALID_HANDLE_VALUE if path is not a socket
> 
> Can you change this to "Returns".

Okay

-------------

PR: https://git.openjdk.java.net/jdk/pull/2424