RFR: 8261744: Implement CharsetDecoder ASCII and latin-1 fast-paths [v2]

Alan Bateman alanb at openjdk.java.net
Wed Feb 17 17:24:46 UTC 2021


On Tue, 16 Feb 2021 19:51:21 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert rem assertions
>
> Great improvement! Looks good to me overall. I wondered about the changes in JLA as Alan already mentioned.

> Right, I'm not exactly sure why the more limited changes I attempted in [5f4e87f](https://github.com/openjdk/jdk/commit/5f4e87f50f49e64b8616063c176ea35632b0347e) failed. In that change I simply changed the initialization order, which made the failing (closed) tests pass locally - but not in our CI. Since this is in initPhase1 there should be no concurrency possible.

The Reference Handler thread is started by the initializer in jl.ref.Reference so could be a candidate. The Finalizer thread is another but this should VM.awaitInitLevel(1) and not touch JLA until initPhase1 is done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2574


More information about the nio-dev mailing list