RFR: 8259014: (so) ServerSocketChannel.bind(UnixDomainSocketAddress)/SocketChannel.bind(UnixDomainSocketAddress) will have unknown user and group owner (win)

Michael McMahon michaelm at openjdk.java.net
Fri Jan 8 10:13:53 UTC 2021


On Thu, 7 Jan 2021 21:15:42 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> src/java.base/windows/native/libnio/ch/UnixDomainSockets.c line 110:
>> 
>>> 108:     if (osver.dwBuildNumber < 18362) {
>>> 109:         return JNI_FALSE;
>>> 110:     }
>> 
>> Can you use VerifyVersionInfoW instead of the deprecated GetVersionEx? The IsWindows10RS3OrGreater function in net_util_md.c is a recent example.
>
> It looks like VerifyVersionInfoW is (or will be) deprecated also and it seems like quite a complicated API that checks the same thing in this case.
> 
> https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-verifyversioninfow

I'm going to close this PR as it should have been on the jdk16 repo. I'll also look at using the other Windows API that does not require a #pragma (for now). Will open a new PR on jdk16 shortly.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1986


More information about the nio-dev mailing list