RFR: JDK-8030048: (fs) Support UserDefinedFileAttributeView/extended attributes on OS X / HFS+

[Sebastian Stenzel]

On Wed, 13 Jan 2021 12:46:50 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> One thing that we need to decide is whether the additional parameters (position, options) are exposed by BsdNativeDispatcher or not. I think I agree with your approach to have the signature match the methods in LinuxNativeDispatcher as that will make it easier to merge the two implementations later.

Just to discuss all options, we could as well hide both params from Java entirely (set them inside of `BsdNativeDispatcher.c`)

> The comments that XATTR_NOFOLLOW is not applicable and other options not used is distracting and can be removed.

Sure, but maybe it should be documented _somewhere_ that none of the flags are required for this use case? Or do you think it is reasonable to assume that anyone stumbling upon this code will just look up the system calls' documentation to see what flags might have been possible?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2017