RFR: 8253478: (se) epoll Selector should use eventfd for wakeup instead of pipe [v7]

Brian Burkhalter bpb at openjdk.java.net
Thu Jan 21 19:34:33 UTC 2021


On Thu, 21 Jan 2021 10:24:53 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8253478: EventFD update: constructors; make native methods private
>
> src/java.base/linux/classes/sun/nio/ch/EventFD.java line 51:
> 
>> 49:     EventFD(boolean blocking) throws IOException {
>> 50:         efd = eventfd0();
>> 51:         IOUtil.configureBlocking(IOUtil.newFD(efd), blocking);
> 
> This looks okay but the addition of the blocking parameter means you can go back to one of the early iterations and just calling eventfd with the EFD_NONBLOCK. Up to you.

I am not sure I understand this comment as a previous comment preferred `IOUtil.configureBlocking()` to set the blocking state.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2082


More information about the nio-dev mailing list