RFR: 8253119: Remove the legacy PlainSocketImpl and PlainDatagramSocketImpl implementation [v6]
Patrick Concannon
pconcannon at openjdk.java.net
Tue Jul 6 10:24:29 UTC 2021
> Hi,
>
> Could someone please review my changes for the removal of the legacy `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>
> In JDK 13, JEP 353 provided a drop in replacement for the legacy `PlainSocketImpl` implementation. Since JDK 13, the `PlainSocketImpl` implementation was no longer used but included a mitigation mechanism to reduce compatibility risks in the form of a JDK-specific property `jdk.net.usePlainSocketImpl` allowing to switch back to the old implementation.
> Similarly, in JDK 15, JEP 373 provided a new implementation for `DatagramSocket` and `MulticastSocket`, with a JDK-specific property `jdk.net.usePlainDatagramSocketImpl` also allowing the user to switch back to the old implementation in case of compatibility issue.
>
> As these implementations (and the mechanisms they use to enable them to mitigate compatibility issues) have been deemed no longer necessary, they now represent a maintenance burden. This patch looks at removing them from the JDK.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
- Merge remote-tracking branch 'origin/master' into JDK-8253119
- 8253119: Fixed typo
- 8253119: Added message to null check in java/net/DatagramSocket
- Merge remote-tracking branch 'origin/master' into JDK-8253119
- 8253119: Removed redundant comments and USE_PLAINDATAGRAMSOCKET from java/net/DatagramSocket
- Merge remote-tracking branch 'origin/master' into JDK-8253119
- 8253119: Remove the legacy PlainSocketImpl and PlainDatagramSocketImpl implementation
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/4574/files
- new: https://git.openjdk.java.net/jdk/pull/4574/files/686b4369..538b145e
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4574&range=05
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4574&range=04-05
Stats: 12821 lines in 436 files changed: 7154 ins; 3504 del; 2163 mod
Patch: https://git.openjdk.java.net/jdk/pull/4574.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/4574/head:pull/4574
PR: https://git.openjdk.java.net/jdk/pull/4574
More information about the nio-dev
mailing list