RFR: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream [v3]

[Jaikiran Pai]

On 05/07/21 10:52 am, Jaikiran Pai wrote:
>
>>> 4. I've never previously created a manual test case. The 
>>> `LargeCompressedEntrySizeTest` in this PR is expected to be a manual 
>>> test case (given how long it might take to run on various different 
>>> systems). The only difference between this test case and other jtreg 
>>> automated tests is the absence of a `@test` on this one. Is this how 
>>> manual tests are written or is there some other way?
>>>
>> We avoid manual tests as there is no guarantee that they will be run. 
>> So maybe we'll need to explore the scenario a bit further to see if 
>> there is some way to come up with an automated test. The jtreg foo 
>> for manual tests is `@run main/manual LargeCompressedEntrySizeTest`. 
>> You'll see a few examples in the test suite but I don't know if they 
>> are ever run.
>
> I have updated the PR to use jtreg's construct of @run testng/manual 
> to mark this as a manual test. I will post the timing of this test 
> case later today after I run the latest version locally and see how 
> long it's taking.
>
On my local setup, the LargeCompressedEntrySizeTest (latest version of 
this PR) consistently takes between 205 to 215 seconds to complete (so 
between 3 to 4 minutes). Is that something that will allow it to be 
added as part of automated tests or is it too long for automated tests?

-Jaikiran