RFR: 8268056: Update java.net and java.nio to use switch expressions [v2]

Patrick Concannon pconcannon at openjdk.java.net
Tue Jun 1 17:20:39 UTC 2021


On Tue, 1 Jun 2021 16:56:36 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Patrick Concannon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8268056: Reverted changes to URLDecoder; reformatted change to FileTime
>
> src/java.base/share/classes/java/net/URLDecoder.java line 228:
> 
>> 226:                         // A trailing, incomplete byte encoding such as
>> 227:                         // "%x" will cause an exception to be thrown
>> 228: 
> 
> This change is a bit difficult to review and there doesn't appear much gain in changing from a regular switch to a switch expression in this case. Maybe we should just keep the regular switch here?

OK. I've reverted change, as suggested. See 2f179b5

-------------

PR: https://git.openjdk.java.net/jdk/pull/4285


More information about the nio-dev mailing list