RFR: 8267564: JDK-8252971 causes SPECjbb2015 socket exceptions on Windows when MKS is installed

Michael McMahon michaelm at openjdk.java.net
Fri Jun 4 08:26:58 UTC 2021


On Fri, 4 Jun 2021 08:18:30 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> src/java.base/windows/native/libnio/ch/UnixDomainSockets.c line 28:
>> 
>>> 26: #ifndef UNICODE
>>> 27: #define UNICODE 1
>>> 28: #endif
>> 
>> Setting UNICODE has wider impact, can you explain why you are adding this? Does it go away if WSASocketW is used instead?
>
> That was why I only set it in this file, but using WSASocketW and WSAEnumProtocolsW (and the corresponding W data types) seems to work.

Concerning the general question about supporting the MKS provider. It has different behavior. For instance the filesystem node created, appears to be a regular file rather than a reparse point (a la Microsoft). We would have to think carefully about these differences if we wanted to support it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4339


More information about the nio-dev mailing list