RFR: 8267564: JDK-8252971 causes SPECjbb2015 socket exceptions on Windows when MKS is installed [v2]
Michael McMahon
michaelm at openjdk.java.net
Fri Jun 4 11:26:15 UTC 2021
> Hi,
>
> This fixes a problem where unix domain sockets are available on Windows from third party winsock drivers (other than the Microsoft implementation in Windows 10/2019). These are available (unexpectedly) on earlier Windows releases and are not supported by Java.
>
> The fix is to search for the expected winsock service provider ID and specifically use that one when creating sockets. Previously, we just attempted to create a unix domain socket, and once that succeeded we assumed we had the right service provider.
>
> I haven't included a regression test because the environment to reproduce the issue is not part of the standard test configuration. Also, the new code is well exercised by existing tests.
>
> Thanks,
> Michael.
Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
update after Alan's comments
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/4339/files
- new: https://git.openjdk.java.net/jdk/pull/4339/files/bd591928..8c4508c4
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4339&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4339&range=00-01
Stats: 29 lines in 1 file changed: 4 ins; 5 del; 20 mod
Patch: https://git.openjdk.java.net/jdk/pull/4339.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/4339/head:pull/4339
PR: https://git.openjdk.java.net/jdk/pull/4339
More information about the nio-dev
mailing list