RFR: 8267564: JDK-8252971 causes SPECjbb2015 socket exceptions on Windows when MKS is installed [v2]

[Michael McMahon]

On Fri, 4 Jun 2021 16:59:46 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> The latest version looks much better. One niggle is that the method to test if Unix domain sockets is supported has a side effect of setting provider. What you would think about renaming to "init" or something better. It can continue to return a boolean to indicate if supported or not.
> 
> I should have been clearer in my comment about cmpGuid. I meant that memcmp returns -1, 0 or 1 and it would have been clearer if have it return JNI_FALSE if it returned something != 0 (it was the !memcpy that was awkward). What you have now is okay.

That's fine. I think init() is a good name. I'll make that change now. Thanks for the review!

- Michael

-------------

PR: https://git.openjdk.java.net/jdk/pull/4339