RFR: JDK-8260966 (fs) Consolidate Linux and macOS implementations of UserDefinedFileAttributeView [v3]

[Thomas Stüfe]

Hi Alan,

On Wed, Mar 3, 2021 at 8:31 AM Alan Bateman <Alan.Bateman at oracle.com> wrote:

> On 03/03/2021 06:53, Thomas Stuefe wrote:
> > :
> > Unfortunately this broke AIX and I don't know if this would work on BSD
> (not sure if anyone still maintains those).
> >
> > https://bugs.openjdk.java.net/browse/JDK-8262926
> >
> The BSD port is in maintained downstream rather than in OpenJDK and no
> requirement that it builds on BSD before integrating changes here. It's
> somewhat historical that there are Bsd* classes here, it dates from
> initial macOS port and Apple contributions in 7u4.
>
> We aren't required to do any building or testing on AIX prior to
> integrating changes. Instead, we've always left it to SAP or IBM to keep
> that port alive. So apologies, there will be periodic breakage and needs
> someone with easy access to AIX systems to keep it working.
>
>
No problem, we are aware of that and usually fix without much noise. Also,
Oracle developers are usually very careful to at least "dry-fix" AIX or at
least ping us, for which we are thankful. On the whole this works quite
well.

In this case I was afraid, due to the PR title, that this fix would involve
major implementation work on our side. Since it looked like Sebastian
unified a lot of code for Linux and MacOs without being aware that there
are other supported Unices. From his initial response I take that this is
an easy fix though.

As for BSD, the hotspot os sources in particular contain code which seems
like it could have bitrotted for the non-mac-platforms. I always suspected
that these configurations are seldom built. But that is a different issue
of course.

Thanks, Thomas


> -Alan
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20210303/6b14ea23/attachment-0001.htm>