RFR: 8262844: (fs) FileStore.supportsFileAttributeView might return false negative in case of ext3 [v2]

[Alan Bateman]

On Wed, 3 Mar 2021 14:48:01 GMT, Arno Zeller <azeller at openjdk.org> wrote:

>> FileStore.supportsFileAttributeView might return a wrong value for ext3 mounts. In case of newer Linux distributions the extended attributes are enabled by default for ext3 mounts and do not show up /proc/mounts.
>> Currently the mount table is parsed to determine whether the mount options contain user_xattr  or nouser_xattr. In case of neither entry it is expected that extended attributes are not supported on ext3. 
>> 
>> This change removes the special handling for ext3 and ext4 and will always probe the fs if none of the options above are found. This should ensure that we return the right value.
>
> Arno Zeller has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Removed special handling for ext4 too
>  - Merge remote-tracking branch 'upstream/master' into LinuxFileStore
>  - Fix ext3 detection in LinuxFileStore

src/java.base/linux/classes/sun/nio/fs/LinuxFileStore.java line 144:

> 142:             }
> 143: 
> 144:             // no other information available so probe mount point

You've removed the special handling for ext4 too, did you mean to do that? I think we'll need to do a lot of testing with this change as I suspect it going to bite back in some unusual configurations.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2778