RFR: 8262844: (fs) FileStore.supportsFileAttributeView might return false negative in case of ext3 [v3]

Alan Bateman alanb at openjdk.java.net
Wed Mar 3 17:56:17 UTC 2021


On Wed, 3 Mar 2021 17:36:25 GMT, Arno Zeller <azeller at openjdk.org> wrote:

>> FileStore.supportsFileAttributeView might return a wrong value for ext3 mounts. In case of newer Linux distributions the extended attributes are enabled by default for ext3 mounts and do not show up /proc/mounts.
>> Currently the mount table is parsed to determine whether the mount options contain user_xattr  or nouser_xattr. In case of neither entry it is expected that extended attributes are not supported on ext3. 
>> 
>> This change removes the special handling for ext3 and ext4 and will always probe the fs if none of the options above are found. This should ensure that we return the right value.
>
> Arno Zeller has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Roll back ext4 changes

Thanks for the analysis. I think we've converged and we are in agreement that we are forced to remove the special handing of ext3.

-------------

Marked as reviewed by alanb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2778


More information about the nio-dev mailing list