RFR: JDK-8262957 (fs) Fail fast in UnixFileStore.isExtendedAttributesEnabled

Alan Bateman alanb at openjdk.java.net
Wed Mar 24 08:49:41 UTC 2021


On Wed, 24 Mar 2021 08:35:45 GMT, Sebastian Stenzel <github.com+1204330+overheadhunter at openjdk.org> wrote:

>> All right, will you create another bug report for the `close(-1)` issue?
>
> I just wanted to create another issue, but then I noticed that `close(-1)` is allowed as per contract: https://github.com/openjdk/jdk/blob/45e1bab87ccebd498d4f927a008dd89a47dd177b/src/java.base/unix/classes/sun/nio/fs/UnixNativeDispatcher.java#L90-L97
> 
> We can still change this, of course, but I wouldn't consider this a necessary change for this PR and would therefore suggest to deal with this another time.

Okay, I had forgotten that that UnixNativeDispatcher.close(-1) is a no-op.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2816


More information about the nio-dev mailing list