RFR: JDK-8264111 (fs) Leaking NativeBuffers in case of errors during UnixUserDefinedFileAttributeView.read/write [v2]

Sebastian Stenzel github.com+1204330+overheadhunter at openjdk.java.net
Thu Mar 25 11:57:56 UTC 2021


> Added new private methods for `read(String name, long address, int rem)` and `write(String name, long address, int rem)` that take an address as an argument and thereby no longer need to deal with any NativeBuffers.
> 
> This allows a certain simplification of `read(String name, ByteBuffer dst)` and `write(String name, ByteBuffer src)` and use of `try (NativeBuffer nb = NativeBuffers.getNativeBuffer(rem)) {...}` which fixes the issue.

Sebastian Stenzel has updated the pull request incrementally with one additional commit since the last revision:

  Added @Override annotation to write(String, ByteBuffer)

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3171/files
  - new: https://git.openjdk.java.net/jdk/pull/3171/files/50e13d31..d3cb759b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3171&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3171&range=00-01

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3171.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3171/head:pull/3171

PR: https://git.openjdk.java.net/jdk/pull/3171


More information about the nio-dev mailing list