RFR: JDK-8264111 (fs) Leaking NativeBuffers in case of errors during UnixUserDefinedFileAttributeView.read/write [v3]

Alan Bateman alanb at openjdk.java.net
Fri Mar 26 09:05:25 UTC 2021


On Thu, 25 Mar 2021 11:37:34 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Sebastian Stenzel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added reachabilityFence when dealing with DirectBuffer
>
> This looks good.
> Would you mind adding "@Override" to the public write method so it is consistent with the other public methods.

Thanks for the update. Can you add the import of java.lang.ref.Reference so that it compiles? Happy to sponsor once the tests are passing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3171


More information about the nio-dev mailing list