RFR: JDK-8264111 (fs) Leaking NativeBuffers in case of errors during UnixUserDefinedFileAttributeView.read/write [v4]

Alan Bateman alanb at openjdk.java.net
Fri Mar 26 14:31:27 UTC 2021


On Fri, 26 Mar 2021 09:16:43 GMT, Sebastian Stenzel <github.com+1204330+overheadhunter at openjdk.org> wrote:

>> Added new private methods for `read(String name, long address, int rem)` and `write(String name, long address, int rem)` that take an address as an argument and thereby no longer need to deal with any NativeBuffers.
>> 
>> This allows a certain simplification of `read(String name, ByteBuffer dst)` and `write(String name, ByteBuffer src)` and use of `try (NativeBuffer nb = NativeBuffers.getNativeBuffer(rem)) {...}` which fixes the issue.
>
> Sebastian Stenzel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   added import

Marked as reviewed by alanb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3171


More information about the nio-dev mailing list