RFR: 8263898: (fs) Files.newOutputStream on the "NUL" special device throws FileSystemException: "nul: Incorrect function" (win) [v6]

Brian Burkhalter bpb at openjdk.java.net
Tue Mar 30 16:16:45 UTC 2021


On Tue, 30 Mar 2021 07:12:35 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8263898: Improve and clean up test
>
> test/jdk/java/nio/file/Files/NulDevice.java line 64:
> 
>> 62: 
>> 63:         try (final FileChannel ch = FileChannel.open(path, CREATE,
>> 64:              TRUNCATE_EXISTING, WRITE)) {
> 
> Did you mean to put a line break here? Same at L87. Asking because it would be easier to read if the open options were on the same line. If line length is the concern then you could drop the spurious "final" modifier.

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3183


More information about the nio-dev mailing list