RFR: 8266369: (se) Add wepoll based Selector [v2]

Alan Bateman alanb at openjdk.java.net
Wed May 5 08:28:51 UTC 2021


On Wed, 5 May 2021 07:45:14 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Alan Bateman has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Merge
>>  - Propagate exception from discardOOB, cleanup
>>  - Merge
>>  - Use 'to' instead of '(int) timeout
>>  - Move SelectorWakeup micro to channels directory
>>  - Initial commit
>
> src/java.base/windows/native/libnio/ch/IOUtil.c line 155:
> 
>> 153: {
>> 154:     char buf[16];
>> 155:     jboolean readBytes = JNI_FALSE;
> 
> Just curious why the drain buffer is 16 bytes now as opposed to 128 previously?

It's only used by the wakeup mechanism so there should only be one byte to drain. So doesn't really matter, except that we don't want it too big as it allocated on the stack.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3816


More information about the nio-dev mailing list