RFR: 8266369: (se) Add wepoll based Selector [v3]

Alan Bateman alanb at openjdk.java.net
Wed May 5 12:21:56 UTC 2021


On Wed, 5 May 2021 12:00:12 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Alan Bateman has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix copyright header on SelectOne benchmark
>
> src/java.base/windows/native/libnio/ch/Net.c line 791:
> 
>> 789: JNIEXPORT jboolean JNICALL
>> 790: Java_sun_nio_ch_Net_discardOOB(JNIEnv* env, jclass clazz, jobject fdo)
>> 791: {
> 
> This seems surprisingly close to the logic of the drain method above (IOUtil.c). Would it make sense to factorize some of it?

For now, this method sits sendOOB. There is some historical/legacy debt in this area in that some methods for network sockets have been added to IOUtil instead of Net. I do plan to re-visit this at some point but I'd prefer not do it in this PR because it requires touching all the Selector implementations.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3816


More information about the nio-dev mailing list