RFR: 8266369: (se) Add wepoll based Selector [v4]
Alan Bateman
alanb at openjdk.java.net
Wed May 5 14:47:51 UTC 2021
On Wed, 5 May 2021 14:42:25 GMT, Patrick Concannon <pconcannon at openjdk.org> wrote:
>> Alan Bateman has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove unused WEPoll.getDescriptor. Update micro to close listener
>
> src/java.base/windows/native/libnio/ch/WEPollNatives.c line 56:
>
>> 54: Java_sun_nio_ch_WEPoll_create(JNIEnv *env, jclass clazz) {
>> 55: HANDLE h = epoll_create1(0);
>> 56: if (h < 0) {
>
> Just wondering should you be checking for `NULL` here instead?
Well spotted, it should check for NULL (a subtle difference with regular epoll_create1).
-------------
PR: https://git.openjdk.java.net/jdk/pull/3816
More information about the nio-dev
mailing list