RFR: 8266589: (fs) Improve performance of Files.copy() on macOS using copyfile(3)

Brian Burkhalter bpb at openjdk.java.net
Thu May 6 18:58:51 UTC 2021


On Thu, 6 May 2021 18:46:56 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> I agree that it would be good to split it up but as part of a yet to be filed issue.
>> 
>> Would you please elaborate on reformatting the callback? Thanks.
>
> I should have been clearer. L58 splits the conditions on two lines with the second line indented 4 spaces so it looks like the 3rd condition is in the block. I think you should re-format it to make it easier to read.

This could be made into one line, no split, or three lines. Otherwise an additional `if` would be needed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3890


More information about the nio-dev mailing list