RFR: 8276634: Remove `usePlainDatagramSocketImpl` option from the test DatagramChannel/SendReceiveMaxSize.java

Mark Sheppard msheppar at openjdk.java.net
Thu Nov 4 12:31:14 UTC 2021


On Thu, 4 Nov 2021 11:39:15 GMT, Patrick Concannon <pconcannon at openjdk.org> wrote:

> Hi,
> 
> Could someone please review my changes for removing `usePlainDatagramSocketImpl` options from the test DatagramChannel/SendReceiveMaxSize.java? 
> 
> The option `usePlainDatagramSocketImpl` was not removed during [JDK-8253119 - Remove the legacy PlainSocketImpl and PlainDatagramSocketImpl implementation](https://bugs.openjdk.java.net/browse/JDK-8253119). As these implementations have now been removed from the JDK, tests no longer need to check against it.
> 
> The test `test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java` as well as `test/jdk/java/nio/channels/DatagramChannel/ChangingAddress.java` still have this option as its removal was overlooked in the original issue. It can now be removed from both tests. 
> 
> 
> Kind regards,
> Patrick

has the property been retained? If it still exists, then it would seem that the test scenarios are still valid.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6252


More information about the nio-dev mailing list