RFR: 8276634: Remove `usePlainDatagramSocketImpl` option from the test DatagramChannel/SendReceiveMaxSize.java

Daniel Fuchs dfuchs at openjdk.java.net
Thu Nov 4 15:02:13 UTC 2021


On Thu, 4 Nov 2021 14:53:18 GMT, Patrick Concannon <pconcannon at openjdk.org> wrote:

> has the property been retained? If it still exists, then it would seem that the test scenarios are still valid.


$ find src/java.base/ -type f | xargs grep usePlainDatagramSocketImpl | wc -l
       0


There's nothing in the code that reads or depends on that property. So retaining it in test doesn't make much sense IMO. In addition though `test/jdk/java/nio/channels/DatagramChannel/ChangingAddress.java` uses a mix of `DatagramSocket` and `DatagramChannel`, `test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java` only uses `DatagramChannel` which never depended on that property in the first place, so having additional `@run` in there was probably a copy-paste mistake.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6252


More information about the nio-dev mailing list