RFR: 8276634: Remove `usePlainDatagramSocketImpl` option from the test DatagramChannel/SendReceiveMaxSize.java

[Mark Sheppard]

On Thu, 4 Nov 2021 11:39:15 GMT, Patrick Concannon <pconcannon at openjdk.org> wrote:

> Hi,
> 
> Could someone please review my changes for removing the `usePlainDatagramSocketImpl` option from the test DatagramChannel/SendReceiveMaxSize.java? 
> 
> The option `usePlainDatagramSocketImpl` was not removed during [JDK-8253119 - Remove the legacy PlainSocketImpl and PlainDatagramSocketImpl implementation](https://bugs.openjdk.java.net/browse/JDK-8253119). As these implementations have now been removed from the JDK, tests no longer need to check against it.
> 
> The test `test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java` as well as `test/jdk/java/nio/channels/DatagramChannel/ChangingAddress.java` still have this option as its removal was overlooked in the original issue. It can now be removed from both tests. 
> 
> 
> Kind regards,
> Patrick

yes, thanks for the clarification Daniel I hadn't read the release note 
but, the release note says

Support for the system properties `jdk.net.usePlainSocketImpl` and `jdk.net.usePlainDatagramSocketImpl`, used to select these implementations, has also been removed. Setting these properties will now have no effect.

So that the fact that the test's have unintentionally remained, actually validates the release note

although arguable there has been a side effect, i.e. test failure not observed previously -- but that could be coincidental

even though these are DatagramChannel test, DatagramChannel does encapsulate (or contains) a DatagramSocket, so may not be altogether irrelevant ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6252