RFR: 8276779: ChannelInputStream.transferTo() uses FileChannel.transferTo(WritableByteChannel) [v11]
Markus KARG
duke at openjdk.java.net
Sat Nov 6 15:16:52 UTC 2021
> As proposed in JDK-8265891, this PR provides an implementation for `Channels.newInputStream().transferTo()` which provide superior performance compared to the current implementation. This PR is a spin-off from https://github.com/openjdk/jdk/pull/4263 and deliberately concentrates **only** on `FileChannel`s. Other types of channels will be discussed in future PRs.
>
> * Prevents transfers through the JVM heap as much as possibly by offloading to deeper levels via NIO, hence allowing the operating system to optimize the transfer.
>
> Using JMH I have benchmarked both, the original implementation and this implementation, and (depending on the used hardware and use case) performance change was approx. doubled performance. A rather similar approach in different use casse was recently implemented by https://github.com/openjdk/jdk/pull/5097 which was reported by even provide 5x performance (https://github.com/openjdk/jdk/pull/5097#issuecomment-897271997).
>
> **Update:** This sub-issue *only* defines the work to be done to implement JDK-8265891 *solely* for the particular case of FileChannel.transferTo(WriteableByteChannel), including special treatment of SelectableByteChannel, as the `master` branch already contains code to handle the specific case of FileChannel.transferTo(FileChannel).
Markus KARG has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
8265891: ChannelInputStream.transferTo() uses FileChannel.transferTo()
This sub-issue defines the work to be done to implement JDK-8265891 solely for the particular case of FileChannel.transferTo(WritableByteChannel), including special treatment of SelectableByteChannel.
Signed-off-by: Markus Karg <markus at headcrashing.eu>
-------------
Changes: https://git.openjdk.java.net/jdk/pull/5179/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5179&range=10
Stats: 63 lines in 2 files changed: 59 ins; 0 del; 4 mod
Patch: https://git.openjdk.java.net/jdk/pull/5179.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/5179/head:pull/5179
PR: https://git.openjdk.java.net/jdk/pull/5179
More information about the nio-dev
mailing list