RFR: 8276661: (fs) UserDefinedFileAttributeView no longer works with long path (win) [v2]

[Brian Burkhalter]

On Wed, 17 Nov 2021 20:14:07 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8276661: Support UNC paths
>
> src/java.base/windows/classes/sun/nio/fs/WindowsPath.java line 185:
> 
>> 183: 
>> 184:     String getPathForWin32Calls(boolean alwaysAddPrefix)
>> 185:         throws WindowsException {
> 
> Minor nit, can you move the "throws WindowsException {" to the previous line.

Fixed.

> src/java.base/windows/classes/sun/nio/fs/WindowsPath.java line 313:
> 
>> 311:         if (!path.startsWith("\\\\")) {
>> 312:             path = "\\\\?\\" + path;
>> 313:         }
> 
> I think the approach looks okay but I wonder if we need to handle the UNC case here.

Addressed in commit 01.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6435