RFR: 8276779: (ch) InputStream returned by Channels.newInputStream should have fast path for SelectableChannels [v16]

Markus KARG duke at openjdk.java.net
Fri Nov 26 17:52:09 UTC 2021


On Tue, 23 Nov 2021 18:39:31 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Markus KARG has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Closing non-claimed resourced
>>    
>>    Signed-off-by: Markus Karg <markus at headcrashing.eu>
>>  - Closing all claimed resources
>>    
>>    Signed-off-by: Markus Karg <markus at headcrashing.eu>
>>  - Tests IllegalBlockingModeException
>>    
>>    Signed-off-by: Markus Karg <markus at headcrashing.eu>
>>  - JavaDoc proposal by Alan Bateman
>>  - 8265891: ChannelInputStream.transferTo() uses FileChannel.transferTo()
>>    
>>    This sub-issue defines the work to be done to implement JDK-8265891 solely for the particular case of FileChannel.transferTo(WritableByteChannel), including special treatment of SelectableByteChannel.
>>    
>>    Signed-off-by: Markus Karg <markus at headcrashing.eu>
>
> test/jdk/java/nio/channels/Channels/TransferTo.java line 194:
> 
>> 192:         try {
>> 193:             // testing arbitrary input (here: empty file) to non-blocking selectable output
>> 194:             try (FileChannel fc = FileChannel.open(Files.createTempFile(null, null));
> 
> As mentioned in a previous PR review, please create the temp file in the test directory and provide a prefix.

With "the test directory", you mean the current working directory `"."`?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5179


More information about the nio-dev mailing list