RFR: 8276994: java/nio/channels/Channels/TransferTo.java leaves multi-GB files in /tmp
Markus KARG
duke at openjdk.java.net
Sat Nov 27 09:02:04 UTC 2021
On Mon, 15 Nov 2021 07:39:09 GMT, Alan Bateman <alanb at openjdk.org> wrote:
> > @AlanBateman @LanceAndersen You are confusing me. Lance requests style changes, while Alan does not want the changes. These answers are incompatible. _Either_ I change the code according Lance's wishes, _or_ we simple drop this PR. Please find a concensus.
>
> I think it's better to pause a moment and understand the environment when jtreg runs tests. The important thing is that the current directory (as in user.dir) will be a scratch directory that jtreg has created. My comments are just pointing out that the bookkeeping proposed in this PR to delete files is not needed that you can just change the test to create the temp file in the current directory. We can leave the try-finally that Lance added in the >2GB tests because they are too big to keep for any post failure analysis.
Understood, so I will create the temp files in `"."` then and provide a reasonable prefix, keep the try-finally from Lance, and do not manually delete other temp files.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6379
More information about the nio-dev
mailing list