RFR: 8273507: Convert test/jdk/java/nio/channels/Channels/TransferTo.java to TestNG test [v4]

Markus KARG github.com+1701815+mkarg at openjdk.java.net
Fri Oct 1 17:09:09 UTC 2021


On Wed, 29 Sep 2021 22:35:29 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Markus KARG has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Comment for checkTransferredContents
>>   
>>   Signed-off-by: Markus Karg <markus at headcrashing.eu>
>
> The comments are much improved but inconsistent. For example some of them have `@param` and other javadoc tags and some do not. There is also some variation in detail level.
> 
> On a process level, it would be better to wait for feedback on changes before integrating. This is especially so as a sponsor has to be comfortable with the content. Ideally at least one approval should be associated with the most recent commit.

@bplb 
> The comments are much improved but inconsistent. For example some of them have `@param` and other javadoc tags and some do not. There is also some variation in detail level.

Maybe Javadoc for test support code is excessive, and is the major source of inconsistency here. I dropped them to be more in line with the rest of comments, see https://github.com/openjdk/jdk/pull/5421/commits/54b7438b72fcfc20889dbb4140ff7aa2d5279642. But beyond that, I don't understand what do you mean about the different level of detail, would you mind suggesting changes where you see fit?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5421


More information about the nio-dev mailing list