RFR: 8274780: ChannelInputStream.readNBytes(int) incorrectly calls readAllBytes() [v2]

Alan Bateman alanb at openjdk.java.net
Wed Oct 6 08:40:21 UTC 2021


On Tue, 5 Oct 2021 20:38:29 GMT, Florian Weimer <fweimer at openjdk.org> wrote:

>> 8274780: ChannelInputStream.readNBytes(int) incorrectly calls readAllBytes()
>
> Florian Weimer has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Simplify dataTest() implementation
>  - Reduce test timeout somewhat (based on default timeout factor)

Marked as reviewed by alanb (Reviewer).

test/jdk/java/nio/channels/Channels/ReadXBytes.java line 139:

> 137:         Path file = c.create(length);
> 138:         try {
> 139:             for (boolean hideSeek : List.of(false, true)) {

It might be a bit clearer if you renamed this to "seekable"

-------------

PR: https://git.openjdk.java.net/jdk/pull/5824


More information about the nio-dev mailing list