RFR: 8273507: Convert test/jdk/java/nio/channels/Channels/TransferTo.java to TestNG test [v8]
Aleksey Shipilev
shade at openjdk.java.net
Mon Oct 18 07:39:53 UTC 2021
On Sat, 16 Oct 2021 08:37:09 GMT, Markus KARG <duke at openjdk.java.net> wrote:
>> Using TestNG makes it easier to maintain and extend the unit test of ChannelInputStream::transferTo.
>>
>> This change was proposed by Brian Burkhalter @blbp and requested Alan Bateman @AlanBateman.
>>
>> *Note: A further test addition (testing 2GB+ transfers) will be added by me in a subsequent PR using TestNG once *this* PR is merged. This will need a while due to personal scheduling, also the topics are not necessarily related, hence there are separate PRs.*
>
> Markus KARG has updated the pull request incrementally with two additional commits since the last revision:
>
> - Added code comments for private methods
>
> Signed-off-by: Markus Karg <markus at headcrashing.eu>
> - Added code comment for public method
>
> Signed-off-by: Markus Karg <markus at headcrashing.eu>
Still looks fine to me.
-------------
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5421
More information about the nio-dev
mailing list