RFR: 8275536: [TEST] java.io.File and java.nio.File should return the same timestamp for lastModified [v2]
Clive Verghese
cverghese at openjdk.java.net
Thu Oct 21 22:54:36 UTC 2021
On Thu, 21 Oct 2021 06:20:31 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Clive Verghese has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update function and variable names
>
> Can you add a bit more information here, or to the JBS issue, on this? Is this something to do with the glibc that Amazon are using?
>
> In general Files::getLastLastModified may return a FileTime of higher precision that the milliseconds returned by File::lastModified so maybe this test is to ensure that improvements are ported to java.io.File too? At some point I expect we will re-implement File to layer over the newer implementation so File will benefit from improvements.
>
> I think test/jdk/java/io/File may be a better place for the test.
Hi @AlanBateman,
Thank you for the feedback, I have moved the test to `tets/jdk/java/io/File` and add some more information regarding this.
Yes, The test is to ensure that improvements to one are ported to both implementations.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6054
More information about the nio-dev
mailing list