RFR: 8270490: Charset.forName() taking fallback default value [v4]
Daniel Fuchs
dfuchs at openjdk.java.net
Tue Oct 26 10:46:09 UTC 2021
On Sat, 23 Oct 2021 22:13:35 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> During the review of JEP 400, a proposal to provide an overloaded method to `Charset.forName()` was suggested [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This PR is to implement the proposal. A CSR is also drafted as https://bugs.openjdk.java.net/browse/JDK-8275348
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>
> Reflecting review comments
src/java.base/share/classes/java/io/Console.java line 590:
> 588: if (cs == null) {
> 589: cs = Charset.forName(StaticProperty.nativeEncoding(),
> 590: Charset.defaultCharset());
I assume that `StaticProperty.nativeEncoding()` will never be `null`? Otherwise an IAE would be thrown here where previously `Charset.defaultCharset()` would be used.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6045
More information about the nio-dev
mailing list