RFR: 8275840: Add test to java/nio/channels/Channels/TransferTo.java to test transfer sizes > 2GB [v2]

[Lance Andersen]

On Tue, 26 Oct 2021 06:59:35 GMT, Markus KARG <duke at openjdk.java.net> wrote:

>> Testing `FileChannel.transferTo(FileChannel)` with more than 2 GB of data is covering the case that *multiple* iterations of `FileChannel.transferTo(FileChannel)` are actually performed by the test.
>> 
>> This change was requested Alan Bateman @AlanBateman.
>
> Markus KARG has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Also it would be better to use constants.
>  - It would probably be better to use a try-with-resources statement here to cleanly close the streams.

test/jdk/java/nio/channels/Channels/TransferTo.java line 143:

> 141:         // writing 3 GB of random bytes into source file
> 142:         int NUM_WRITES = 3 * 1024;
> 143:         int BYTES_PER_WRITE = 1024 * 1024;

We typically do not capitalize local variables, we  capitalize constants(Brian was suggesting the use of constants).

Using constants adds consistency with their use elsewhere.

If you choose to use a local variable, the variable name should not be capitalized

test/jdk/java/nio/channels/Channels/TransferTo.java line 155:

> 153: 
> 154:         // comparing reported transferred bytes, must be 3 GB
> 155:         assertEquals(count, (long) NUM_WRITES * BYTES_PER_WRITE);

This could also be a constant (similar to MAX_SIZE_INCR)

-------------

PR: https://git.openjdk.java.net/jdk/pull/6093