RFR: JDK-8273038: ChannelInputStream.transferTo() uses FileChannel.transferTo(FileChannel) [v12]

Tue Sep 7 11:46:37 UTC 2021

On Tue, 7 Sep 2021 07:49:22 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> The override of InputStream::transferTo is calling FileChannel::transferTo in a loop so I don't think it is unreasonable to ask if we have test that has more than one iteration. I'm okay if we defer this to a further step but I do think we should have test for this case.

I will look into testing the 2 GB+ iterations after this PR is merged and I'm done with my TestNG PR.

> > It actually reads "2014, 2021" which means that the original code was first published in 2014 and was last modified in 2021. Oracle once asked me to always do it _exactly that way_ when touching any Oracle source code (which I did here, as the test originated from existing Oracle source code). If OpenJDK is an exceptional case here, then please confirm that I am _officially allowed_ to remove the year 2014 from that list. Until then I have to keep the line exactly the way it is to not get into any troubles with Oracle's legal department.
> This is a new test, the date should be 2021.

Done with https://github.com/openjdk/jdk/pull/5209/commits/1804aa00f34010a174301ac3d816de23806e179f.

So this PR is fine for merging now? :-)

-------------

PR: https://git.openjdk.java.net/jdk/pull/5209