Integrated: JDK-8273038: ChannelInputStream.transferTo() uses FileChannel.transferTo(FileChannel)

Markus KARG github.com+1701815+mkarg at openjdk.java.net
Wed Sep 8 11:25:25 UTC 2021


On Sat, 21 Aug 2021 14:33:43 GMT, Markus KARG <github.com+1701815+mkarg at openjdk.org> wrote:

> As proposed in JDK-8265891, this PR provides an implementation for `Channels.newInputStream().transferTo()` which provide superior performance compared to the current implementation. This PR is a spin-off from https://github.com/openjdk/jdk/pull/4263 and https://github.com/openjdk/jdk/pull/5179 and deliberately concentrates **only** on the case where both, source **and** target, are actually `FileChannel`s. Other types of channels will be discussed in future PRs.
> 
> * Prevents transfers through the JVM heap as much as possibly by offloading to deeper levels via NIO, hence allowing the operating system to optimize the transfer.
> 
> Using JMH I have benchmarked both, the original implementation and this implementation, and (depending on the used hardware and use case) performance change was approx. doubled performance. A rather similar approach in different use casse was recently implemented by https://github.com/openjdk/jdk/pull/5097 which was reported by even provide 5x performance (https://github.com/openjdk/jdk/pull/5097#issuecomment-897271997).

This pull request has now been integrated.

Changeset: 18555742
Author:    Markus Karg <markus at headcrashing.eu>
Committer: Alan Bateman <alanb at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/185557423d3069d627daecdf87315a49d6597b67
Stats:     464 lines in 4 files changed: 384 ins; 76 del; 4 mod

8273038: ChannelInputStream.transferTo() uses FileChannel.transferTo(FileChannel)

Reviewed-by: alanb

-------------

PR: https://git.openjdk.java.net/jdk/pull/5209


More information about the nio-dev mailing list