RFR: 8273507: Using TestNG for unit testing ChannelInputStream::transferTo [v2]

Markus KARG github.com+1701815+mkarg at openjdk.java.net
Thu Sep 9 06:26:29 UTC 2021


> Using TestNG makes it easier to maintain and extend the unit test of ChannelInputStream::transferTo.
> 
> This change was proposed by Brian Burkhalter @blbp and requested Alan Bateman @AlanBateman.
> 
> *Note: A further test addition (testing 2GB+ transfers) will be added by me in a subsequent PR using TestNG once *this* PR is merged. This will need a while due to personal scheduling, also the topics are not necessarily related, hence there are separate PRs.*

Markus KARG has updated the pull request incrementally with one additional commit since the last revision:

  Using assert* methods instead of fail() and expectedExceptions
  
  Signed-off-by: Markus Karg <markus at headcrashing.eu>

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5421/files
  - new: https://git.openjdk.java.net/jdk/pull/5421/files/1d08b967..b37ad6b3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5421&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5421&range=00-01

  Stats: 24 lines in 1 file changed: 4 ins; 13 del; 7 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5421.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5421/head:pull/5421

PR: https://git.openjdk.java.net/jdk/pull/5421


More information about the nio-dev mailing list