RFR: 8274242: Implement fast-path for ASCII-compatible CharsetEncoders on x86 [v5]

Volker Simonis simonis at openjdk.java.net
Tue Sep 28 11:53:22 UTC 2021


On Tue, 28 Sep 2021 10:01:43 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Not too much work. I recently introduced platform-specific `matcher_*.hpp` files, so since then adding a boolean constant is easy (no need to muck with the .ad files).
>
> Does the changes in 9800a99 resolve your concerns?

In principle yes, but shouldn't the condition read:

if (!Matcher::match_rule_supported(Op_EncodeISOArray) || !Matcher::supports_encode_ascii_array) return false;

I.e. the intrinisc is supported if both conditions are true and not supported if either one of them is false?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5621


More information about the nio-dev mailing list