RFR: 8285485: Fix typos in corelibs
Roger Riggs
rriggs at openjdk.java.net
Wed Apr 27 15:53:32 UTC 2022
On Fri, 22 Apr 2022 15:08:51 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> I ran `codespell` on modules owned by core-libs, and accepted those changes where it indeed discovered real typos.
>
> I will update copyright years using a script before pushing (otherwise like every second change would be a copyright update, making reviewing much harder).
>
> The long term goal here is to make tooling support for running `codespell`. The trouble with automating this is of course all false positives. But before even trying to solve that issue, all true positives must be fixed. Hence this PR.
Since you've changed some code; you need to run tests for tiers 1-3.
(Note that even for trivial changes, hundreds of OpenJDK developers are notified and distracted; be considerate of other developers).
src/java.xml/share/classes/com/sun/xml/internal/stream/XMLEventReaderImpl.java line 140:
> 138: } else if(type == XMLEvent.START_ELEMENT) {
> 139: throw new XMLStreamException(
> 140: "elementGetText() function expects text only element but START_ELEMENT was encountered.", event.getLocation());
Should we be fixing typos in third party software; it can easily get wiped out in an update.
src/java.xml/share/classes/com/sun/xml/internal/stream/writers/WriterUtility.java line 97:
> 95: }
> 96: else{
> 97: //attempt to retrieve default fEncoderoder
"fEncoderoder" looks out of place, please recheck.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8364
More information about the nio-dev
mailing list